Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the resource settings models of following tracked NRP resources #10468

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Updated the resource settings models of following tracked NRP resources #10468

merged 1 commit into from
Aug 18, 2020

Conversation

innosam
Copy link
Contributor

@innosam innosam commented Aug 14, 2020 •
edited
Loading

  1. Updated the resource settings models of following tracked NRP resources:
  • Network Interfaces
  • Network Security Groups
  • Virtual Networks
  • Loadbalancers
  • Public IP
  1. Fix GO SDK generation.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 14, 2020 •
edited
Loading

[Staging] Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings [Detail] [Expand]
Rule Message
❌ 1008 - ModifiedOperationId The operation id has been changed from 'MoveCollection_Update' to 'MoveCollections_Update'. This will impact generated code.
New: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L81:7
Old: Microsoft.Migrate/preview/2019-10-01-preview/regionmovecollection.json#L81:7
️️✔️LintDiff [Detail] 
 Validation passes for LintDiff.
️️✔️Avocado [Detail] 
 Validation passes for Avocado.
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 14, 2020 •
edited
Loading

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from f675c11 with merge commit c529e5d. SDK Automation 13.0.17.20200807.2 
    Failed to find any changed packages. Please check the changed file list.
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/_configuration.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/_region_move_service_api.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/models/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/models/_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/models/_models_py3.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/models/_paged_models.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/models/_region_move_service_api_enums.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/operations/__init__.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/operations/_move_collections_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/operations/_move_resources_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/operations/_operations_discovery_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/operations/_unresolved_dependencies_operations.py
/z/work/azure-sdk-for-python/sdk/azure-mgmt/regionmove/version.py

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 14, 2020 •
edited
Loading

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 14, 2020 •
edited
Loading

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from f675c11 with merge commit c529e5d. SDK Automation 13.0.17.20200807.2 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 14, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 14, 2020 •
edited
Loading

azure-sdk-for-js - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from f675c11 with merge commit c529e5d. SDK Automation 13.0.17.20200807.2 
    Failed to find any diff after autorest so no changed packages was found.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 14, 2020 •
edited
Loading

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 14, 2020 •
edited
Loading

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 14, 2020 •
edited
Loading

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 14, 2020 •
edited
Loading

azure-resource-manager-schemas - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from f675c11 with merge commit c529e5d. Schema Automation 13.0.17.20200807.2
  • ⚠️regionmove [View full logs]  [Release Schema Changes] 
      [after_scripts|node] PostProcessor finished successfully.
[after_scripts|node]   5608 passing (1m)
[after_scripts|node]   1 failing
AzureResourceSchema has no registered package commands.

    @innosam innosam force-pushed the hsingh/regionmovenetworkresourcesettingsupdate branch from e9288ef to c426839 Compare August 14, 2020 06:05
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Aug 14, 2020
    Closed
    @innosam innosam force-pushed the hsingh/regionmovenetworkresourcesettingsupdate branch from c426839 to 931bfc5 Compare August 14, 2020 06:12
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @innosam innosam force-pushed the hsingh/regionmovenetworkresourcesettingsupdate branch from 931bfc5 to b102b59 Compare August 14, 2020 06:48
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @innosam innosam changed the title Updated the resource settings models of following tracked NRP resourc… Updated the resource settings models of following tracked NRP resources Aug 14, 2020
    @innosam innosam force-pushed the hsingh/regionmovenetworkresourcesettingsupdate branch from b102b59 to 9b64e50 Compare August 14, 2020 08:39
    @azure-pipelines
    Copy link

    Pull request contains merge conflicts.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @innosam innosam force-pushed the hsingh/regionmovenetworkresourcesettingsupdate branch from 312a335 to 55de293 Compare August 14, 2020 09:14
    @azure-pipelines
    Copy link

    Pull request contains merge conflicts.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @innosam innosam force-pushed the hsingh/regionmovenetworkresourcesettingsupdate branch from 3ead286 to 47ed816 Compare August 14, 2020 09:22
    @azure-pipelines
    Copy link

    Pull request contains merge conflicts.

    @innosam innosam force-pushed the hsingh/regionmovenetworkresourcesettingsupdate branch from 47ed816 to 389fb23 Compare August 14, 2020 09:23
    @innosam
    Updated the resource settings models of following tracked NRP resourc…
    f675c11 
    …es and related models:

Network Interfaces
Network Security Groups
Virtual Networks
Loadbalancers
Public IP
    @innosam innosam force-pushed the hsingh/regionmovenetworkresourcesettingsupdate branch from 77f8f40 to f675c11 Compare August 17, 2020 13:08
    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ArcturusZhang ArcturusZhang added BreakingChangeReviewRequired Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed BreakingChangeReviewRequired labels Aug 18, 2020
    @ArcturusZhang
    Copy link
    Member

    approved breaking changes since this is a preview api within one year

    @ArcturusZhang ArcturusZhang merged commit c529e5d into Azure:master Aug 18, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

    @atpham256 atpham256 Awaiting requested review from atpham256

    @blueww blueww Awaiting requested review from blueww

    @giakas giakas Awaiting requested review from giakas

    @heaths heaths Awaiting requested review from heaths

    @hyonholee hyonholee Awaiting requested review from hyonholee

    @jaredmoo jaredmoo Awaiting requested review from jaredmoo

    @matthchr matthchr Awaiting requested review from matthchr

    @MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

    @naveedaz naveedaz Awaiting requested review from naveedaz

    @novinc novinc Awaiting requested review from novinc

    @RandalliLama RandalliLama Awaiting requested review from RandalliLama

    @solankisamir solankisamir Awaiting requested review from solankisamir

    @stankovski stankovski Awaiting requested review from stankovski

    @TimLovellSmith TimLovellSmith Awaiting requested review from TimLovellSmith

    @yangyuan yangyuan Awaiting requested review from yangyuan

    Assignees

    @ArcturusZhang ArcturusZhang

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @innosam @azuresdkci @ArcturusZhang